Remove Copy-on-Write warning mode from tests #57237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
approved these changes
Feb 4, 2024
Member
|
Thanks @phofl |
Comment on lines
-121
to
-139
| df = df_orig.copy() | ||
| df["a"] # populate the item_cache | ||
| if using_copy_on_write: | ||
| with tm.raises_chained_assignment_error(): | ||
| df["a"].fillna(1, inplace=True) | ||
| else: | ||
| with tm.assert_cow_warning(match="A value"): | ||
| df["a"].fillna(1, inplace=True) | ||
|
|
||
| df = df_orig.copy() | ||
| ser = df["a"] # populate the item_cache and keep ref | ||
| if using_copy_on_write: | ||
| with tm.raises_chained_assignment_error(): | ||
| df["a"].fillna(1, inplace=True) | ||
| else: | ||
| # TODO(CoW-warn) ideally also warns on the default mode, but the ser' _cacher | ||
| # messes up the refcount | ||
| with tm.assert_cow_warning(warn_copy_on_write, match="A value"): | ||
| df["a"].fillna(1, inplace=True) |
Member
There was a problem hiding this comment.
We might want to keep this part, as there is some behaviour that is relevant for the warning in true CoW mode as well (not only for the warning mode), xref #56456
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.